Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Ignore all malformed objects when ignore_malformed is true (#4494) #4566

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

hauck-jvsh
Copy link
Contributor

@hauck-jvsh hauck-jvsh commented Sep 21, 2022

Adding DCO

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

…h-project#4494)

Fixes a bug to not fail the entire document when "ignore_malformed" is set to true. Allowing the valid fields
to be indexed and ignore only the malformed fields.

(cherry picked from commit 45c9597)
Signed-off-by: Hauck <joaoh14@gmail.com>
@hauck-jvsh hauck-jvsh force-pushed the backport/backport-4494-to-2.x branch from ed54568 to d93da07 Compare September 22, 2022 18:17
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@hauck-jvsh hauck-jvsh changed the title Ignore all malformed objects when ignore_malformed is true (#4494) [Backport 2.x] Ignore all malformed objects when ignore_malformed is true (#4494) Sep 22, 2022
Copy link
Collaborator

@reta reta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hauck-jvsh the target branch seems to be wrong? please target 2.x (needs rebase I believe)

@hauck-jvsh hauck-jvsh changed the base branch from backport/backport-4494-to-2.x to 2.x September 23, 2022 14:43
@hauck-jvsh
Copy link
Contributor Author

hauck-jvsh commented Sep 23, 2022

Now is it correct?

@reta reta merged commit 4b7b5d5 into opensearch-project:2.x Sep 23, 2022
@hauck-jvsh hauck-jvsh deleted the backport/backport-4494-to-2.x branch September 27, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants